Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new cli option '--use-greptime-cn-artifacts'" #143

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 28, 2023

Related issue: #93.

@zyy17 zyy17 requested a review from shawnh2 August 28, 2023 08:11
@codecov-commenter
Copy link

Codecov Report

Merging #143 (271060a) into develop (fbf59e3) will decrease coverage by 0.04%.
The diff coverage is 36.84%.

@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
- Coverage    31.82%   31.78%   -0.04%     
===========================================
  Files            9        9              
  Lines         1279     1293      +14     
===========================================
+ Hits           407      411       +4     
- Misses         778      788      +10     
  Partials        94       94              
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/helm/helm.go 52.07% <50.00%> (-0.48%) ⬇️

@shawnh2 shawnh2 merged commit 6a86dbd into GreptimeTeam:develop Aug 28, 2023
6 checks passed
@zyy17 zyy17 deleted the feat/support-cn-charts branch August 28, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants