-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support bitnamic etcd chart and add charts cache #135
feat: support bitnamic etcd chart and add charts cache #135
Conversation
6f2baf2
to
320d156
Compare
Codecov Report
@@ Coverage Diff @@
## develop #135 +/- ##
============================================
+ Coverage 21.94% 34.38% +12.44%
============================================
Files 8 8
Lines 948 1079 +131
============================================
+ Hits 208 371 +163
+ Misses 683 621 -62
- Partials 57 87 +30
|
in e2e, it seems has trouble creating the cluster |
2f9cf2c
to
047238f
Compare
@shawnh2 The PDB resources(generated by bitnami etcd chart) that use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's changed
Render
and rename toManager
, and simplify the interface(the user only need to call one APILoadAndRenderChart()
);Related issues