Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ease the restriction of the original "SelectExpr" #794

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

MichaelScofield
Copy link
Collaborator

@MichaelScofield MichaelScofield commented Dec 27, 2022

fix: ease the restriction of the original "SelectExpr" since we used to pass SQLs other than selection in the related GRPC interface

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix #770 (comment)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

…to pass SQLs other than selection in the related GRPC interface
@waynexia waynexia changed the title fix: ease the restriction of the original "SelectExpr" since we used … fix: ease the restriction of the original "SelectExpr" Dec 27, 2022
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #794 (f4b89d8) into develop (3978931) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #794      +/-   ##
===========================================
- Coverage    85.47%   85.37%   -0.11%     
===========================================
  Files          417      417              
  Lines        54302    54297       -5     
===========================================
- Hits         46414    46355      -59     
- Misses        7888     7942      +54     
Flag Coverage Δ
rust 85.37% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/client/src/database.rs 70.22% <100.00%> (ø)
src/datanode/src/instance/flight.rs 33.76% <100.00%> (+0.83%) ⬆️
src/datanode/src/instance/grpc.rs 83.94% <100.00%> (ø)
src/frontend/src/instance.rs 77.79% <100.00%> (ø)
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
tests-integration/src/test_util.rs 87.98% <0.00%> (-11.54%) ⬇️
src/datanode/src/instance.rs 32.40% <0.00%> (-11.18%) ⬇️
src/servers/src/error.rs 45.23% <0.00%> (-7.15%) ⬇️
src/servers/src/grpc.rs 91.17% <0.00%> (-2.95%) ⬇️
src/servers/src/opentsdb.rs 96.82% <0.00%> (-1.59%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit a14ec94 into GreptimeTeam:develop Dec 27, 2022
@MichaelScofield MichaelScofield deleted the fix/grpc-other-sql branch December 27, 2022 09:01
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
)

fix: ease the restriction of the original "SelectExpr" since we used to pass SQLs other than selection in the related GRPC interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants