-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: subquery test migrated from duckdb #4985
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4985 +/- ##
==========================================
- Coverage 84.05% 83.76% -0.30%
==========================================
Files 1144 1148 +4
Lines 213324 214132 +808
==========================================
+ Hits 179318 179361 +43
- Misses 34006 34771 +765 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM, @waynexia PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, please state the original test file in duckdb, and which case(s) are skipped in *.sql file's header
@waynexia PTAL |
Updated with sources and skipped cases. Since they distributed seperately, so I add comments for skipped cases in where they should have been. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#1168
What's changed and what's your intention?
As titile.
Only a few parts are migrated. Mostly because other parts are not available for greptimedb for these reasons:
SELECT (SELECT max((SELECT subq_0.c0 AS c1))) FROM (SELECT NULL AS c0) AS subq_0;
SELECT (SELECT max((SELECT subq_0.c0 AS c1 FROM (SELECT NULL AS c0) AS subq_0)));
Checklist