Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upgrade ci dependencies and switch to nextest #446

Merged
merged 8 commits into from
Nov 10, 2022

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Nov 10, 2022

Changes

This PR upgrades dependencies of CI to fixes the warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, arduino/setup-protoc@v1, actions-rs/toolchain@v1, actions-rs/cargo@v1

Also switches to nextest to allow setting timeout for tests.

Since actions-rs lacks maintenance, this PR uses dtolnay/rust-toolchain to replaced actions-rs/toolchain and removes the usage of actions-rs/cargo

Unresolved Problems

Upgrading setup-protoc is blocked by arduino/setup-protoc#45

Related Issues

This fixes #441

v2.0.0 uses API that is deprecated
actions-rs/toolchain is under inactive maintenance, it uses node12 that
would soon becomes deprecated
Also sets timeout for nextest to avoid a test hanging too long
To upgrade node from 12 to 16
@evenyag evenyag force-pushed the ci/improve-coverage branch 3 times, most recently from 89be9dc to 8cad9a3 Compare November 10, 2022 09:52
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #446 (8cad9a3) into develop (e62b302) will increase coverage by 3.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #446      +/-   ##
===========================================
+ Coverage    84.01%   87.38%   +3.37%     
===========================================
  Files          397      387      -10     
  Lines        39283    47737    +8454     
===========================================
+ Hits         33003    41717    +8714     
+ Misses        6280     6020     -260     
Flag Coverage Δ
rust 87.38% <ø> (+3.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/table/src/requests.rs 28.57% <0.00%> (-55.30%) ⬇️
src/datanode/src/instance.rs 36.88% <0.00%> (-47.21%) ⬇️
src/common/telemetry/src/macros.rs 78.43% <0.00%> (-21.57%) ⬇️
src/meta-srv/src/service/router.rs 72.91% <0.00%> (-16.60%) ⬇️
src/datatypes/src/vectors/helper.rs 50.00% <0.00%> (-13.64%) ⬇️
src/common/catalog/src/helper.rs 84.69% <0.00%> (-11.05%) ⬇️
src/servers/src/http/handler.rs 69.11% <0.00%> (-10.89%) ⬇️
src/meta-srv/src/handler.rs 76.74% <0.00%> (-9.93%) ⬇️
src/frontend/src/frontend.rs 34.37% <0.00%> (-9.11%) ⬇️
src/datatypes/src/types/primitive_type.rs 84.61% <0.00%> (-8.72%) ⬇️
... and 353 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 3ae7362 into develop Nov 10, 2022
@evenyag evenyag deleted the ci/improve-coverage branch November 10, 2022 11:21
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* ci: Upgrade rust-cache to v2.2.0

v2.0.0 uses API that is deprecated

* ci: Use --workspace in cargo llvm-cov

* ci: Replace actions-rs/toolchain by dtolnay/rust-toolchain

actions-rs/toolchain is under inactive maintenance, it uses node12 that
would soon becomes deprecated

* ci: Replace actions-rs/cargo by run

* ci: rust-cache and cleanup-disk-action try not to specific full version

* ci: Use nextest

Also sets timeout for nextest to avoid a test hanging too long

* ci: Upgrade actions/checkout to v3

To upgrade node from 12 to 16

* ci: Specific cleanup-disk-action version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: switch test harness to nextest
3 participants