-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Upgrade ci dependencies and switch to nextest #446
Conversation
v2.0.0 uses API that is deprecated
actions-rs/toolchain is under inactive maintenance, it uses node12 that would soon becomes deprecated
Also sets timeout for nextest to avoid a test hanging too long
To upgrade node from 12 to 16
08375f4
to
6305823
Compare
89be9dc
to
8cad9a3
Compare
Codecov Report
@@ Coverage Diff @@
## develop #446 +/- ##
===========================================
+ Coverage 84.01% 87.38% +3.37%
===========================================
Files 397 387 -10
Lines 39283 47737 +8454
===========================================
+ Hits 33003 41717 +8714
+ Misses 6280 6020 -260
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* ci: Upgrade rust-cache to v2.2.0 v2.0.0 uses API that is deprecated * ci: Use --workspace in cargo llvm-cov * ci: Replace actions-rs/toolchain by dtolnay/rust-toolchain actions-rs/toolchain is under inactive maintenance, it uses node12 that would soon becomes deprecated * ci: Replace actions-rs/cargo by run * ci: rust-cache and cleanup-disk-action try not to specific full version * ci: Use nextest Also sets timeout for nextest to avoid a test hanging too long * ci: Upgrade actions/checkout to v3 To upgrade node from 12 to 16 * ci: Specific cleanup-disk-action version
Changes
This PR upgrades dependencies of CI to fixes the warning:
Also switches to nextest to allow setting timeout for tests.
Since
actions-rs
lacks maintenance, this PR usesdtolnay/rust-toolchain
to replacedactions-rs/toolchain
and removes the usage ofactions-rs/cargo
Unresolved Problems
Upgrading
setup-protoc
is blocked by arduino/setup-protoc#45Related Issues
This fixes #441