Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): flow node addr key #4164

Closed
wants to merge 3 commits into from

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Jun 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4094

What's changed and what's your intention?

add a key to store mapping from flownode id to addr

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    added a mapping from flownode id to flownode addr, so that in distributed mode can flownode be registered and discover(which will be in a subsequent PR)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 18, 2024
@discord9 discord9 marked this pull request as ready for review June 18, 2024 08:55
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 50.70423% with 35 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (ea2d067) to head (6cd958c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4164      +/-   ##
==========================================
- Coverage   85.16%   84.86%   -0.31%     
==========================================
  Files        1021     1022       +1     
  Lines      179241   179311      +70     
==========================================
- Hits       152650   152169     -481     
- Misses      26591    27142     +551     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on this in #4166.

@discord9
Copy link
Contributor Author

Close for #4166

@discord9 discord9 closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants