Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inverted_index.search): add fst applier #2851

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Nov 30, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

FstApplier is a broad term that denotes an abstraction that accepts an Fst and returns values(Vec<u64>).

The primary reason for proposing this abstraction is to allow for preprocessing of certain Predicates, especially for InLists, so it is known from the outset which keys to retrieve. By using these keys to perform a Fst::get(), the desired results can be obtained. Other predicates have a wider scope and require additional APIs from the Fst, such as fst::range() and fst::search().

The FstApplier serves as a suitable abstraction to encompass the implementations of the various scenarios described above.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2705

The next PRs to be submitted:
feat(inverted_index.search): add fst values mapper
feat(inverted_index.search): add index applier

Signed-off-by: Zhenchi <[email protected]>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #2851 (8fdd24f) into develop (fe2fc72) will decrease coverage by 0.32%.
Report is 1 commits behind head on develop.
The diff coverage is 95.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2851      +/-   ##
===========================================
- Coverage    84.76%   84.44%   -0.32%     
===========================================
  Files          737      740       +3     
  Lines       115748   116192     +444     
===========================================
+ Hits         98112    98124      +12     
- Misses       17636    18068     +432     

Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cool Job!

@waynexia waynexia added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit 58c1373 Dec 4, 2023
13 checks passed
@zhongzc zhongzc self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants