test: add write test for region failover #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
commented
May 30, 2023
17 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1673 +/- ##
===========================================
- Coverage 85.72% 85.52% -0.21%
===========================================
Files 573 573
Lines 91963 92033 +70
===========================================
- Hits 78839 78707 -132
- Misses 13124 13326 +202 |
WenyXu
force-pushed
the
test/region-failover
branch
2 times, most recently
from
68d2988
to
41eb878
Compare
killme2008
reviewed
May 30, 2023
WenyXu
force-pushed
the
test/region-failover
branch
from
cbd8f29
to
1bf81ab
Compare
WenyXu
force-pushed
the
test/region-failover
branch
from
ea51523
to
f25c0e7
Compare
MichaelScofield
approved these changes
May 31, 2023
NiwakaDev
reviewed
Jun 12, 2023
| @@ -17,5 +17,9 @@ mod grpc; | |||
| #[macro_use] | |||
| mod http; | |||
|
|
|||
| grpc_tests!(File, S3, S3WithCache, Oss, Azblob); | |||
| http_tests!(File, S3, S3WithCache, Oss, Azblob); | |||
There was a problem hiding this comment.
Good catch! I think that was because I didn't rebase the PR to the latest develop branch. I'm going fix it 👀 Thks @NiwakaDev
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* test: add write test for region failover * test: add written data assertion after failover * test: support more storage types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Test datanode nodes writing after region failover
Checklist
Refer to a related PR or issue link (optional)
#1126