feat: implement CloseRegionHandler #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
WenyXu
force-pushed
the
feat/close-region
branch
2 times, most recently
from
ca9db42
to
317945d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1569 +/- ##
===========================================
- Coverage 85.72% 85.27% -0.46%
===========================================
Files 556 563 +7
Lines 89573 90022 +449
===========================================
- Hits 76785 76762 -23
- Misses 12788 13260 +472 |
WenyXu
force-pushed
the
feat/close-region
branch
2 times, most recently
from
d6c7d15
to
9845b34
Compare
WenyXu
force-pushed
the
feat/close-region
branch
2 times, most recently
from
eb3dd4b
to
a1e7767
Compare
killme2008
reviewed
May 22, 2023
|
Is this PR containing part of #1596? If so, I suggest converting this PR to draft before that one is merged. |
|
PATL @killme2008 |
MichaelScofield
approved these changes
May 23, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: implement CloseRegionHandler * feat: register heartbeat response handlers * test: add tests for heartbeat response handlers * fix: drop table does not release regions * chore: apply suggestion from CR * fix: fix close region issue * chore: apply suggestion from CR * chore: apply suggestion from CR * chore: apply suggestion from CR * chore: apply suggestion from CR * chore: apply suggestion from CR * chore: apply suggestion from CR * chore: apply suggestion from CR * chore: modify method name and add log * refactor: refactor HeartbeatResponseHandler * chore: apply suggestion from CR * refactor: remove close method from Region trait * chore: apply suggestion from CR * chore: remove PartialEq from CloseTableResult * chore: apply suggestion from CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Implement CloseRegionHandler
Checklist
Refer to a related PR or issue link (optional)
#1126