feat: sort the show tables/databases results

GreptimeTeam · Jan 4, 2023 · 91bbe6c · 91bbe6c
1 parent 88d1b66
commit 91bbe6c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/query/src/sql.rs b/src/query/src/sql.rs
@@ -92,7 +92,9 @@ pub fn show_databases(stmt: ShowDatabases, catalog_manager: CatalogManagerRef) -
         .context(error::CatalogNotFoundSnafu {
             catalog: DEFAULT_CATALOG_NAME,
         })?;
-    let databases = catalog.schema_names().context(error::CatalogSnafu)?;
+    let mut databases = catalog.schema_names().context(error::CatalogSnafu)?;
+    // TODO(dennis): Specify the order of the results in catalog manager API
+    databases.sort();
 
     let databases = if let ShowKind::Like(ident) = stmt.kind {
         Helper::like_utf8(databases, &ident.value).context(error::VectorComputationSnafu)?
@@ -134,7 +136,9 @@ pub fn show_tables(
         .schema(DEFAULT_CATALOG_NAME, &schema)
         .context(error::CatalogSnafu)?
         .context(error::SchemaNotFoundSnafu { schema })?;
-    let tables = schema.table_names().context(error::CatalogSnafu)?;
+    let mut tables = schema.table_names().context(error::CatalogSnafu)?;
+    // TODO(dennis): Specify the order of the results in schema provider API
+    tables.sort();
 
     let tables = if let ShowKind::Like(ident) = stmt.kind {
         Helper::like_utf8(tables, &ident.value).context(error::VectorComputationSnafu)?

diff --git a/tests/cases/standalone/catalog/schema.result b/tests/cases/standalone/catalog/schema.result
@@ -7,8 +7,8 @@ SHOW DATABASES;
 +---------+
 | Schemas |
 +---------+
-| test    |
 | public  |
+| test    |
 +---------+
 
 CREATE TABLE test.hello(i BIGINT TIME INDEX);