Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Filters as Cover and Fluid Pipes with Covers #2640

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

ghzdude
Copy link
Contributor

@ghzdude ghzdude commented Oct 15, 2024

What

add an "allow flow" button for filters as covers that is only shown when on Filter Drain or Fill
prevent fluid pipes from pushing at all through a fluid pump

Implementation Details

reworked the filtered handler in the item/fluid filter cover to make sense

Outcome

inserting through a filter set to filter extract is possible
you don't need to disconnect pumps to ensure the pump is the only thing transferring fluid

@ghzdude ghzdude added the type: refactor Suggestion to refactor a section of code label Oct 15, 2024
fix issues with logic
add lang
@ghzdude ghzdude marked this pull request as ready for review October 16, 2024 00:06
@ghzdude ghzdude requested a review from a team as a code owner October 16, 2024 00:06
Copy link
Member

@bruberu bruberu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the allow flow text is slightly clarified, this lgtm!

@ghzdude ghzdude requested a review from bruberu October 21, 2024 01:05
@bruberu bruberu merged commit 185bd5a into GregTechCEu:master Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants