Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item-on-item and github action issues #491

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Fix item-on-item and github action issues #491

merged 6 commits into from
Mar 17, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Mar 17, 2024

No description provided.

Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@d79f5d0). Click here to learn what that means.

Files Patch % Lines
.../gregs/voidps/world/activity/skill/ItemOnItems.kts 50.00% 0 Missing and 2 partials ⚠️
.../voidps/engine/data/config/ItemOnItemDefinition.kt 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage        ?   26.33%           
  Complexity      ?     3938           
=======================================
  Files           ?     1219           
  Lines           ?    38582           
  Branches        ?     8163           
=======================================
  Hits            ?    10162           
  Misses          ?    25743           
  Partials        ?     2677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GregHib GregHib merged commit 157f695 into main Mar 17, 2024
3 checks passed
@GregHib GregHib deleted the fix-item-on-item branch March 17, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants