Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grimy herb cleaning for herblore #481

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Grimy herb cleaning for herblore #481

merged 7 commits into from
Mar 15, 2024

Conversation

Syntax2022
Copy link
Contributor

  • Add Cleaning data class Cleaning.kt
  • Add HerbCleaning.kts for herb cleaning logic
  • Add level requirement XP reward on each grimy herb in items.yml

* Add `HerbCleaning.kts` for herb cleaning logic
* Add `level requirement` `XP reward` on each grimy herb in `items.yml`
@Syntax2022
Copy link
Contributor Author

Syntax2022 commented Mar 14, 2024

Am i correct in thinking if i called player.softTimers.start("timername") it will automatically overwrite any existing timer because the name is the same or should i be calling

if(player.softTimers.contains("timername")){
        player.softTimers.restart("timername")
} else {
        player.softTimers.start("timername")
}

@GregHib
Copy link
Owner

GregHib commented Mar 14, 2024

Actually it'll just queue another timer with the same name, which would start calling timerTick twice a tick, which is not ideal and a bit of an oversight, I'll create an issue for it.

For context the timer's used in the other skills are mainly for the bots so that they can know when a skill they're performing has started/stopped/failed. In this case herbs take a fixed amount of time and never fail so don't worry about having such a timer.

@GregHib GregHib mentioned this pull request Mar 14, 2024
6 tasks
* Add a check if the player already has a weak queue and clear it before starting a new one
@GregHib GregHib merged commit 3020438 into GregHib:main Mar 15, 2024
2 checks passed
@Syntax2022 Syntax2022 deleted the skills branch March 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants