Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inventory storage disconnect #497

Closed
GregHib opened this issue Mar 19, 2024 · 2 comments
Closed

Improve inventory storage disconnect #497

GregHib opened this issue Mar 19, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@GregHib
Copy link
Owner

GregHib commented Mar 19, 2024

There's a disconnect between inventories.inventories[name] and inventories.inventory(name).items as StateManager changes the underlying data array
@GregHib GregHib added the bug Something isn't working label Mar 19, 2024
GregHib added a commit that referenced this issue Mar 19, 2024
@GregHib
Fix inventory saving #497
0ae80bc
@GregHib GregHib added the enhancement New feature or request label Mar 19, 2024
@GregHib
Copy link
Owner Author

GregHib commented Mar 19, 2024

I've updated PlayerSave so it now correctly saves the latest, but this is not a great solution and could potentially be exploitable

@GregHib GregHib mentioned this issue Mar 19, 2024
Merged
GregHib added a commit that referenced this issue Mar 19, 2024
@GregHib
Add publishing images to DockerHub (#496)
0743852 
* Add Dockerfile and publishing to DockerHub

* Add docker badge to readme

* Fix inventory saving #497

* Remove prayer debug info

* Fix level up

* Reuse Properties in koin
GregHib added a commit that referenced this issue Mar 22, 2024
@GregHib
Combine inventory data with inventories #497
48ffe5e
GregHib added a commit that referenced this issue Mar 22, 2024
@GregHib
Move login and logout out of Player and into PlayerAccounts #497
e93d877
GregHib added a commit that referenced this issue Mar 23, 2024
@GregHib
Combine inventory data with inventories #497
a002b03
GregHib added a commit that referenced this issue Mar 23, 2024
@GregHib
Move login and logout out of Player and into PlayerAccounts #497
5627b5b
@GregHib GregHib mentioned this issue Mar 23, 2024
Merged
GregHib added a commit that referenced this issue Mar 28, 2024
@GregHib
Refactor networking module (#501)
4f9aaca 
* Combine inventory data with inventories #497

* Move login and logout out of Player and into PlayerAccounts #497

* Move login response out of PlayerAccounts

* Move password validation earlier in login server

* Reuse account connection for bots

* Move password encryption into networking module

* Move ClientManager into networking

* Move LoginManager into PlayerAccountLoader

* Remove accounts online from PlayerAccountLoader

* Rename ClientManager to ConnectionTracker

* Remove unused NetworkQueue interface

* Move instruct into client

* Rename instruct to instruction

* Move Instruction to client

* Move game server files

* Move login server files

* Move encoders

* Move decoders

* Move decoder

* Move jag extensions

* Move visuals into protocol

* Move connection tracker into client

* Move Protocol

* Add Server tests

* Add PlayerAccountLoader to koin

* Move visual encoders into Encoders.kt

* Add networking code coverage module

* Split PlayerAccounts into AccountManager and SaveQueue

* Add player account tests

* Move ConnectionQueue into networking

* Move indexing into CharacterList

* Remove IndexAllocator

* Add decoder tests

* Remove unused decoders

* Add encoder tests, store all expected byte arrays into .csv resources

* Store test huffman in resources

* Add fallback safe account storage in case of primary failure

* Fix bot spawns
@GregHib
Copy link
Owner Author

GregHib commented Mar 28, 2024

Room for improvement but good enough for now.

@GregHib GregHib closed this as completed Mar 28, 2024
@GregHib GregHib added this to Void Jul 8, 2024
@GregHib GregHib moved this to Done in Void Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
Void
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GregHib