Fix/wallet upgrades #175
Draft
Fix/wallet upgrades #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 1, 2021
mzyau
commented
Mar 1, 2021
| @@ -414,7 +414,7 @@ class Wallet{ | |||
| if( | |||
| trustRelationship.actor_wallet_id === senderWallet.getId() && | |||
| trustRelationship.target_wallet_id === receiveWallet.getId() && | |||
| trustRelationship.request_type === TrustRelationship.ENTITY_TRUST_REQUEST_TYPE.send | |||
| trustRelationship.request_type === trustType | |||
There was a problem hiding this comment.
This hasTrust method in wallet model was not actually referencing the trustType parameter sent in, so I changed it to be more flexible to reuse for checking other request types
mzyau
commented
Mar 1, 2021
| @@ -274,9 +274,9 @@ describe("Wallet", () => { | |||
| target_wallet_id: wallet.getId(), | |||
| }]); | |||
| const result = await wallet.hasTrust( | |||
| TrustRelationship.ENTITY_TRUST_TYPE.send, | |||
| wallet, | |||
| TrustRelationship.ENTITY_TRUST_REQUEST_TYPE.receive, | |||
There was a problem hiding this comment.
As a result of my change on hasTrust method referencing the trust type parameter now, I also think this test should expect a "receive" request type (should not be sending an entity trust type). Since wallet2 (actor, receiver) is sending a receive request to wallet (target, sender).
@mzyau I think we also need to mock this |
|
@dadiorchen Can you fix this for @mzyau as an example? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.