feat: implement v2 for get /countries/leaderboard #97
Conversation
| ), | ||
| ); | ||
| expect(response.status).toBe(200); | ||
| expect(response.body.countries[0]).toMatchObject({ |
There was a problem hiding this comment.
For the leaderboard test, it might be beneficial to check which specific country is first in the array. I believe tree 1 is located in USA, tree 2 is located in Canada, so you could expect either Canada or USA. Maybe include more trees in your seed file to definitively have 1 country appear in the first array.
There was a problem hiding this comment.
I have added another tree planted in the US to make the top country specific. Now it checks if the country is US and if the number of trees planted is 2.
| async function seed() { | ||
| knexConfig.searchPath = [process.env.DATABASE_SCHEMA, 'webmap']; | ||
| const serverCon = knex(knexConfig); | ||
| const response = await serverCon.transaction(async (trx) => { |
There was a problem hiding this comment.
It would be good to rename the existing raw_capture_feature table to another name (say temp_raw_capture_feature), then fill a newly created table with your seed data and name it to raw_capture_feature for your test. The test can proceed to completion, then you can delete the created table and rename temp_raw_capture_feature back to raw_capture_feature. This way will avoid clearing actual test data once ETL scripts begin to populate raw_capture_feature, and you won't have to rewrite leaderboard tests to account for the the new data in the table. You can use this knex documentation.
There was a problem hiding this comment.
Oh, yes, I know this is annoying, but, just don't touch the tables in public , you all can freely delete data under webmap schema, that's totally fine, because we didn't use that table for web map presentation.
And the next step would be use dedicated database for test, so we can do anything safely, there already are good practice in other our microservice for this, so we can learn what they are doing
There was a problem hiding this comment.
For me, I run a docker image of postgresql, and run db-migrate to set up the database, then I can run the test fastly, for other API service, like: earnings-api
There was a problem hiding this comment.
I am not deleting any data from the public schema. The data addition and deletion is all in the webmap schema. So I don't see the need to create new tables because the intention is to finally add a single set of data that would be used to do all the tests on the webmap schema.
|
@dagmawig thank your for you great job! |
|
@dagmawig Oh, I have reviewed this PR is good enough to merge, I just forgot to click the button. |
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes issue #96
Added leaderboard method to V2 API. Test automatically clears
raw_capture_featuretable then populates it with known data, completes the test and clears the table at the end of testing.