Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: species v2 #359

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: species v2 #359

merged 1 commit into from
Sep 27, 2023

Conversation

aayushgauba
Copy link
Contributor

Species V2 doesnot use herbarium.species and follows legacy version. This fixes that

@dadiorchen
Copy link
Contributor

@aayushgauba thank you for your contribution, but there are some problem with this PR, I think majorly it is a problem of communication, in the v2 version, we can not use tables in herbarium because we will delay that part and got a bigger plan on herbarium system, so in a very long future there wouldn't be any data in herbarium, actually, we will use the species table in treetracker so can you change this to use that table?
I think to avoid this in the future, we can use the project board and issue ticket to improve the communication, like, creating a issue for this PR first, and assigning it to the developer and once you start to work on it, you can make it in status=In Progress, in this way, I think it is more likely we can do a early discussion on this, and find out the misunderstanding.
Thank you for help us pushing this forward!

@aayushgauba
Copy link
Contributor Author

aayushgauba commented Sep 24, 2023

@dadiorchen I assume that the table is treetracker.species right?

@dadiorchen
Copy link
Contributor

yes

@dadiorchen dadiorchen merged commit cb251a1 into Greenstand:main Sep 27, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.70.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants