Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing column in earnings table #66

Open
philnorc opened this issue Mar 30, 2022 · 5 comments
Open

Missing column in earnings table #66

philnorc opened this issue Mar 30, 2022 · 5 comments

Comments

@philnorc
Copy link

According to testCases.md,
https://github.com/Greenstand/treetracker-earnings-api/blob/main/docs/test/testCases.md,
the earnings table should have a column
"Sub organization name"
Neither the test panel nor the dev panel have that column.
https://test-admin.treetracker.org/earnings
https://dev-admin.treetracker.org/earnings

@dadiorchen
Copy link
Contributor

The same as Greenstand/treetracker-admin-client#612

@philnorc
Copy link
Author

No. 66 & 67 are not the same.
Greenstand/treetracker-admin-client#612 concerns the column "Count of Captures" in the payments table.
#66 concerns the column "Sub organization" in the earnings table.

@dadiorchen
Copy link
Contributor

@philnorc yes, you are right!

@philnorc
Copy link
Author

philnorc commented Apr 8, 2022

The missing column for "Organization" is particularly a problem because we provide a filter option for Organization. It is hard to use a filter for values you cannot see.

And where do the values in the Organization menu come from? They do not include the only organizations I see in the data: Child One, Child Two, Greenstand, and null.

@dadiorchen
Copy link
Contributor

Yes, I agree, I added this feature to milestone 2, because adding this feature cause change on both back end and front end, it's risky to add it at this testing round stage.

The org menu is from the infrastructure of the admin panel, there are some problems with the authentication workflow, so you find it's incorrect, we will figure it out in the future, and also it's not the problem of earning tool (it's about stakeholder system)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants