-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: duplicate capture v1: display distance between two selected captures #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync forked repo
amesk3
changed the title
feat: duplicate capture v1: display distance between two selected captures #781
feat: duplicate capture v1: display distance between two selected captures
Oct 2, 2022
nmcharlton
force-pushed
the
duplicate-capture-781
branch
from
October 2, 2022 18:21
2b945c8
to
be469d2
Compare
nmcharlton
requested changes
Oct 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of tests that are now failing. Could you take a look? They may need updating to reflect the changes you've made.
npm run test
nmcharlton
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an effort to distinguish duplicate captures, this feature gets the distance between two currently selected features.
Issue(s) addressed
Duplicate verification issue.
Issue 781
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
N/A
What is the new behavior?
On /verify, when two selections are selected, Side Panel displays the distance between the two selections based off of their lat/lon. There is now label beneath the Select All and Select None buttons: Distance between selected captures: x.x m when two captures are selected
Breaking change
Does this PR introduce a breaking change?
Other useful information
This is the first part of addressing the duplicate image verification issue.