Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: duplicate capture v1: display distance between two selected captures #863

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

amesk3
Copy link
Contributor

@amesk3 amesk3 commented Oct 2, 2022

Description

In an effort to distinguish duplicate captures, this feature gets the distance between two currently selected features.

Issue(s) addressed
Duplicate verification issue.

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
N/A

What is the new behavior?
On /verify, when two selections are selected, Side Panel displays the distance between the two selections based off of their lat/lon. There is now label beneath the Select All and Select None buttons: Distance between selected captures: x.x m when two captures are selected

Breaking change

Does this PR introduce a breaking change?

Other useful information

This is the first part of addressing the duplicate image verification issue.

@amesk3 amesk3 requested a review from a team as a code owner October 2, 2022 00:03
@amesk3 amesk3 changed the title feat: duplicate capture v1: display distance between two selected captures #781 feat: duplicate capture v1: display distance between two selected captures Oct 2, 2022
@amesk3
Copy link
Contributor Author

amesk3 commented Oct 2, 2022

image

image

image

Different scenarios of there being nothing selected, 2 captures selected, and more than 2 captures selected.

@nmcharlton nmcharlton force-pushed the duplicate-capture-781 branch from 2b945c8 to be469d2 Compare October 2, 2022 18:21
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of tests that are now failing. Could you take a look? They may need updating to reflect the changes you've made.

npm run test

src/components/SidePanel.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@nmcharlton nmcharlton merged commit a05cdb5 into Greenstand:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants