Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Verify) - eliminating unnecessary re-rendering #843 #846

Merged
merged 1 commit into from
Oct 1, 2022
Merged

refactor(Verify) - eliminating unnecessary re-rendering #843 #846

merged 1 commit into from
Oct 1, 2022

Conversation

Vlad-Pischaeff
Copy link
Contributor

@Vlad-Pischaeff Vlad-Pischaeff commented Sep 25, 2022

Description

Getting rid of unnecessary re-renders, some little enhances

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
Re-renders after each browser window resizing

What is the new behavior?
Smooth picture changing after browser window resizing

Breaking change

Does this PR introduce a breaking change?
No

Other useful information

@Vlad-Pischaeff Vlad-Pischaeff requested a review from a team as a code owner September 25, 2022 04:34
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vlad-Pischaeff!

@nmcharlton nmcharlton merged commit d5c9d02 into Greenstand:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify - do we need to update the logic of the component?
2 participants