fix: add spinner to prevent previous capture appearance #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @marinakosova, thanks for working on this. Please could you include a screen recording of this fix in action? |
@nmcharlton I added a video link. |
nmcharlton
approved these changes
Sep 19, 2022
|
Thank you @nmcharlton for approval. Should I now click "Close with comment" button? |
No, the issue will be automatically closed when I merge this PR into master. For now I'm pausing merges while we complete the microservice migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[I used CircularProgress component provided by Material UI and I added it to the CaptureDetailDialog.js file. For the OptimizedImage component I added a new method onImageReady() to be able to check the loading of an image. Now while waiting for an image to load you will see a green spinner instead of previously selected image.]
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
What is the new behavior?
Video of the new behavior
Breaking change
Does this PR introduce a breaking change?
Other useful information