Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display unique devices and if they're iOS or Android #279

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

gwynndp
Copy link
Collaborator

@gwynndp gwynndp commented Jan 9, 2022

Description

Display the device identifiers for both admin and org accounts and make sure there aren't duplicates

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Comments were added to explain the device manufacturers displayed

Issue

What is the current behavior?

  • devices aren't displaying for org account
  • duplicate devices are displaying for the admin account

What is the new behavior?

  • unique devices are displayed for both admin and org accounts

Other useful information

@nmcharlton nmcharlton merged commit 01dd684 into Greenstand:master Jan 9, 2022
mitia-anah pushed a commit to mitia-anah/treetracker-admin-client that referenced this pull request Feb 1, 2022
Ny-Rianala pushed a commit to Ny-Rianala/treetracker-admin-client that referenced this pull request Feb 10, 2022
@gwynndp gwynndp deleted the dedup-device-identifiers branch February 23, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants