Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grower-detail): display device manufacturer with device id #196

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

gwynndp
Copy link
Collaborator

@gwynndp gwynndp commented Nov 13, 2021

Description

Add device operating system to the GrowerDetail

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Enhancement

Issue

What is the current behavior?

Only displays device identifiers at the bottom of the GrowerDetail drawer right now.

What is the new behavior?

Display the operating system next to the device identifier in a table at the bottom of the GrowerDetail

Steps taken:

  • Update deviceIdentifier state to include the device OS
  • Display the device id and the OS on the GrowerDetail component

Breaking change

Does this PR introduce a breaking change?

  • No

Growers - Treetracker Admin by Greenstand 2021-11-13 11-15-50

src/components/GrowerDetail.js Outdated Show resolved Hide resolved
@gwynndp gwynndp force-pushed the display-ios-android branch from 389fac7 to ae0d3fc Compare November 15, 2021 01:08
@gwynndp gwynndp requested a review from nmcharlton November 19, 2021 02:01
@nmcharlton nmcharlton merged commit ba9158f into Greenstand:master Nov 24, 2021
@gwynndp gwynndp deleted the display-ios-android branch February 23, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planter module: Easy way to determine if the app was Android or IOS
2 participants