Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(capture): enables scrolling in Capture page #182

Merged
merged 5 commits into from
Oct 30, 2021
Merged

fix(capture): enables scrolling in Capture page #182

merged 5 commits into from
Oct 30, 2021

Conversation

mqnguyen5
Copy link
Contributor

Fixes #176

This PR enables vertical scrolling in the Capture page by changing the overflow: hidden property into overflowX: 'hidden' and overflowY:'scroll'

osd_release_greenstand

@nmcharlton nmcharlton removed the request for review from luacmartins October 28, 2021 19:30
nmcharlton
nmcharlton requested changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It be great if the content could scroll and the toolbar stay visible at the top.
Check out the Growers page for similar behaviour.

@mqnguyen5
Copy link
Contributor Author

I have added some adjustments. @nmcharlton do you mind taking a look again?

nmcharlton
nmcharlton requested changes Oct 28, 2021
View reviewed changes
src/components/CaptureTable.js Outdated Show resolved Hide resolved
nmcharlton
nmcharlton approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @mqnguyen5!

@mqnguyen5 mqnguyen5 mentioned this pull request Oct 29, 2021
Closed
@mqnguyen5
Copy link
Contributor Author

The fixes for #183 is included in here as well, as I forgot to open a new branch for the issue. @nmcharlton do you mind checking it for me?

@nmcharlton nmcharlton linked an issue Oct 30, 2021 that may be closed by this pull request
Capture page pagination does not behave as expected #183
Closed
nmcharlton
nmcharlton requested changes Oct 30, 2021
View reviewed changes
src/components/CaptureTable.js Outdated Show resolved Hide resolved
@mqnguyen5
Copy link
Contributor Author

Hi @nmcharlton , I have updated the code, please have a look when you have time. Thanks.

nmcharlton
nmcharlton approved these changes Oct 30, 2021
View reviewed changes
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work

@nmcharlton nmcharlton merged commit 9d2a145 into Greenstand:master Oct 30, 2021
@mqnguyen5
Copy link
Contributor Author

Hi @nmcharlton , if possible, could you please add a hacktoberfest-accepted label to this PR? I would really appreciate it. Thanks!

@nmcharlton nmcharlton added the Hackathon February 2023 Hackathon Material label Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmcharlton nmcharlton nmcharlton approved these changes

@gwynndp gwynndp Awaiting requested review from gwynndp

Assignees
No one assigned
Labels
Hackathon February 2023 Hackathon Material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture page pagination does not behave as expected Cannot scroll Captures page
2 participants
@mqnguyen5 @nmcharlton