Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tokenized to Verify/Trees filter and Tree Detail #53

Closed
nmcharlton opened this issue Mar 26, 2021 · 5 comments · Fixed by #112
Closed

Add Tokenized to Verify/Trees filter and Tree Detail #53

nmcharlton opened this issue Mar 26, 2021 · 5 comments · Fixed by #112
Assignees
Labels
dependency: api Depends on a change to a Greenstand API size: medium Medium-size issue tool: Captures Relates to the capture data tool (Captures page, formerly Trees) tool: Verify Relates to the capture verification tool (Verify page) type: enhancement New feature or request

Comments

@nmcharlton
Copy link
Collaborator

If a capture has a non-null token_id in the database, it is considered Tokenized.

We need to display whether or not a capture is Tokenized (in Tree Detail) and allow the user to filter on this value in the Verify and Trees pages (see #51 which aims to consolidate the filters on the two pages).

@nmcharlton nmcharlton added the type: enhancement New feature or request label Mar 26, 2021
@nmcharlton nmcharlton added tool: Captures Relates to the capture data tool (Captures page, formerly Trees) tool: Verify Relates to the capture verification tool (Verify page) size: medium Medium-size issue labels Apr 10, 2021
@nmcharlton
Copy link
Collaborator Author

This will require a supporting change in treetracker-admin-api.

@VLuisa
Copy link
Contributor

VLuisa commented Jun 5, 2021

I can pick this one up!

@VLuisa
Copy link
Contributor

VLuisa commented Jun 9, 2021

@nmcharlton I'm less familiar with how Redux is set up in the app and how to go about adding in a new ajax request to get access to the token_id data (not sure if I'm even approaching this correctly) - mind giving me some pointers on how to get the right query for the token_id built in and where to do that? I'm wondering whether it makes sense to create two queries, one that looks for all null tokenIds and one that looks for all non-null

@nmcharlton
Copy link
Collaborator Author

@VLuisa You can simply add a tokenId property to the where filter object passed as a parameter to the existing trees query (see models/Filter.js).

Check the LoopBack docs for how to form the clause to query null/non-null values.

@VLuisa
Copy link
Contributor

VLuisa commented Jun 9, 2021

@nmcharlton Ah ok, makes sense. I was definitely overcomplicating it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency: api Depends on a change to a Greenstand API size: medium Medium-size issue tool: Captures Relates to the capture data tool (Captures page, formerly Trees) tool: Verify Relates to the capture verification tool (Verify page) type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants