Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: planter filter to allow filtering parent orgs by name and all orgs by id #164

Merged
merged 3 commits into from
Sep 24, 2021
Merged

fix: planter filter to allow filtering parent orgs by name and all orgs by id #164

merged 3 commits into from
Sep 24, 2021

Conversation

gwynndp
Copy link
Collaborator

@gwynndp gwynndp commented Sep 20, 2021 •
edited
Loading

  • replaced text box with an org dropdown to filter orgs on Planters page
  • admin can filter by parent org names in a dropdown on both Planters and Verify pages
  • org account can filter by sub-org names in a dropdown on both Planters and Verify pages

There is a related PR for the api here: Greenstand/treetracker-admin-api#589

Closes: #159, #161

@gwynndp gwynndp requested a review from nmcharlton September 20, 2021 20:38
@gwynndp gwynndp force-pushed the add-orgfilter-planters branch 2 times, most recently from 7b8e956 to 258526e Compare September 23, 2021 00:26
@gwynndp gwynndp force-pushed the add-orgfilter-planters branch from 258526e to 9f9ce86 Compare September 23, 2021 00:33
@gwynndp gwynndp marked this pull request as ready for review September 23, 2021 01:37
@nmcharlton nmcharlton linked an issue Sep 24, 2021 that may be closed by this pull request
Critical: Can not filter by Organization id when logged in with user role #161
Closed
nmcharlton
nmcharlton approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@nmcharlton nmcharlton merged commit ee3b6f0 into Greenstand:master Sep 24, 2021
@gwynndp gwynndp deleted the add-orgfilter-planters branch February 23, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmcharlton nmcharlton nmcharlton approved these changes

@luacmartins luacmartins Awaiting requested review from luacmartins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gwynndp @nmcharlton