fix: planter filter to allow filtering parent orgs by name and all orgs by id #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gwynndp
commented
Sep 20, 2021
•
gwynndp
commented
- updated /planter and /count endpoints to get both parent and child org entityIds and and planter ids for the query
- updated /organization/{orgid}/planter, .../trees, and .../count endpoints to check if an org filter was requested, compare it to the org account id, and override the value in the query if it's a sub-org
- updated /organizations to get all the parent orgs for admin and all the sub-orgs for an org account
dadiorchen
approved these changes
Sep 24, 2021
|
My only concern is that there appears to be a lot of duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.