Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [#133] add reset button and enter keydown functionality to planter view filter #134

Merged
merged 3 commits into from
Jul 14, 2021
Merged

feat: [#133] add reset button and enter keydown functionality to planter view filter #134

merged 3 commits into from
Jul 14, 2021

Conversation

thejoshcooter
Copy link
Member

@thejoshcooter thejoshcooter commented Jul 14, 2021 •
edited by nmcharlton
Loading

Resolves #133

@thejoshcooter thejoshcooter changed the title [#133] feat: add reset button and enter keydown functionality to planter view filter feat: [#133] add reset button and enter keydown functionality to planter view filter Jul 14, 2021
@thejoshcooter
Copy link
Member Author

Features added for the issue, but I did notice that on the Verify view we use a form setup whereas we do not on the Planter view. These two could also probably be refactored into a single component later to ensure they stay in sync as things change which was one of the primary reasons behind this ticket.

@thejoshcooter thejoshcooter marked this pull request as ready for review July 14, 2021 20:01
@thejoshcooter thejoshcooter mentioned this pull request Jul 14, 2021
Closed
@nmcharlton
Copy link
Collaborator

Features added for the issue, but I did notice that on the Verify view we use a form setup whereas we do not on the Planter view. These two could also probably be refactored into a single component later to ensure they stay in sync as things change which was one of the primary reasons behind this ticket.

That's a great shout. We use filters like this in a few places and will be adding more soon. A reusable component that allows us to configure the fields and specify the Apply handler would be a great help.

nmcharlton
nmcharlton approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@nmcharlton nmcharlton merged commit b0fc39b into Greenstand:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmcharlton nmcharlton nmcharlton approved these changes

@gwynndp gwynndp Awaiting requested review from gwynndp

@luacmartins luacmartins Awaiting requested review from luacmartins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planter filter: Reset button and Apply on enter
2 participants
@thejoshcooter @nmcharlton