Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planter filter: Reset button and Apply on enter #133

Closed
nmcharlton opened this issue Jul 13, 2021 · 2 comments · Fixed by #134
Closed

Planter filter: Reset button and Apply on enter #133

nmcharlton opened this issue Jul 13, 2021 · 2 comments · Fixed by #134
Assignees
@thejoshcooter
Labels
good first issue Good for newcomers size: small Simple change tool: Growers Relates to the Grower Management tool (Growers page, formerly Planters) type: enhancement New feature or request

Comments

@nmcharlton
Copy link
Collaborator

The filter in the Verify tool has two features that would be useful in the Planters filter:

  1. A Reset button that sets filters fields back to their default values (empty/null)
  2. Pressing enter triggers Apply

Verify filter:
Screenshot 2021-07-13 at 08 31 18

Planters filter:
Screenshot 2021-07-13 at 08 31 36

We should strive for consistency across these components.
@nmcharlton nmcharlton added type: enhancement New feature or request good first issue Good for newcomers tool: Growers Relates to the Grower Management tool (Growers page, formerly Planters) size: small Simple change labels Jul 13, 2021
@thejoshcooter
Copy link
Member

@nmcharlton I can take care of this Nick

@thejoshcooter
Copy link
Member

Open PR and comments here.

@nmcharlton nmcharlton mentioned this issue Jul 14, 2021
Merged
nmcharlton pushed a commit that referenced this issue Jul 14, 2021
@thejoshcooter
feat: [#133] add reset button and enter keydown functionality to plan…
b0fc39b 
…ter view filter (#134)

* feat: add reset button and functionality to planter filter

* feat: add filter reset functionality to planters view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thejoshcooter thejoshcooter

Labels
good first issue Good for newcomers size: small Simple change tool: Growers Relates to the Grower Management tool (Growers page, formerly Planters) type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: [#133] add reset button and enter keydown functionality to planter view filter
2 participants
@thejoshcooter @nmcharlton