Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping feature #923

Merged
merged 27 commits into from
Aug 19, 2024
Merged

Add mapping feature #923

merged 27 commits into from
Aug 19, 2024

Conversation

manushak
Copy link
Contributor

@manushak manushak commented Jul 26, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • add mapping to the manifest schema.
  • to test add a mapping block like this
mapping:  
   'parameter-name-in-the-plugin': 'parameter-name-in-the-input'

@manushak manushak self-assigned this Jul 26, 2024
@manushak manushak linked an issue Jul 26, 2024 that may be closed by this pull request
3 tasks
const pluginSettings = {
'global-config': globalConfig,
'parameter-metadata': {},
mapping: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there cases where mapping is used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add use cases for every unit test


```yaml
mapping:
'old-name': 'new-name'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not clear where the mapping should be. f.ex. in plugin settings or in context

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you're right. In this case, I think it will be good to remove from the plugin's readme file

@manushak manushak marked this pull request as draft August 2, 2024 11:17
@manushak manushak marked this pull request as ready for review August 5, 2024 10:38
@manushak manushak marked this pull request as draft August 8, 2024 05:27
@manushak manushak marked this pull request as ready for review August 12, 2024 13:36
@jmcook1186 jmcook1186 merged commit c4c345a into main Aug 19, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the mapping-feature branch August 19, 2024 12:08
This was referenced Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameter mapping feature
3 participants