-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapping
feature
#923
Add mapping
feature
#923
Conversation
const pluginSettings = { | ||
'global-config': globalConfig, | ||
'parameter-metadata': {}, | ||
mapping: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there cases where mapping is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add use cases for every unit test
|
||
```yaml | ||
mapping: | ||
'old-name': 'new-name' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not clear where the mapping should be. f.ex. in plugin settings or in context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, you're right. In this case, I think it will be good to remove from the plugin's readme file
…ded` helpers function
Types of changes
A description of the changes proposed in the Pull Request
mapping
to the manifest schema.mapping
block like this