Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build If-check #865

Merged
merged 25 commits into from
Jun 28, 2024
Merged

Build If-check #865

merged 25 commits into from
Jun 28, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Add functionality to check if the provided manifest outputs are correct
  • There are 2 cases to test:
  • When you provide manifest file path: npm run if-check — -m ./manifests/outputs/manifest.yaml. If the outputs are the same as the generated manifest file, it should print Files match! or 

    Files do not match! tree.children.child.outputs.0.cpu/energy source: 0.08333333333333333 target: 0.1
  • When you provide a directory path where placed manifests files are: npm run if-check — -d ./manifests/output/. It should print every file name with the execution result

@manushak manushak self-assigned this Jun 27, 2024
@manushak manushak linked an issue Jun 27, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, but could you remove the < and > characters wrapping tyhe filename in the response message?

i.e. like this:

if-check could not verify teads-curve.yml

not this

if-check could not verify <teads-curve.yml>

@manushak manushak requested a review from MariamKhalatova June 27, 2024 15:58
@MariamKhalatova
Copy link
Contributor

When folder doesn't contain any yamls, only checking message is shown.
Expected Behavior: Folder is empty, or similar message.

Screenshot 2024-06-28 at 1 47 33 AM

@MariamKhalatova
Copy link
Contributor

When running with prefix weird error appears.

Screenshot 2024-06-28 at 1 56 00 AM

@jmcook1186
Copy link
Contributor

lgtm - thanks :o)

@jmcook1186 jmcook1186 merged commit 95ebafb into main Jun 28, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the if-check2 branch June 28, 2024 12:30
This was referenced Jun 28, 2024
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build if-check
4 participants