Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add if core as a source of errors #838

Merged
merged 11 commits into from
Jun 14, 2024
Merged

Add if core as a source of errors #838

merged 11 commits into from
Jun 14, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Import all errors from if-core plugin

@narekhovhannisyan narekhovhannisyan self-assigned this Jun 13, 2024
@narekhovhannisyan narekhovhannisyan changed the title Add if core Add if core as a source of errors Jun 13, 2024
@@ -3,7 +3,7 @@ import {z} from 'zod';
import {ExecutePlugin, PluginParams} from '../../types/interface';

import {validate} from '../../util/validations';
import {ERRORS} from '../../util/errors';
import {ERRORS} from '@grnsft/if-core';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the top and update it in the other files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's coming in next PR

@narekhovhannisyan narekhovhannisyan merged commit d8a49b2 into main Jun 14, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the add-if-core branch June 14, 2024 12:23
@narekhovhannisyan
Copy link
Member Author

#593

This was referenced Jun 28, 2024
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants