Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate sci plugin to builtins #704

Merged
merged 13 commits into from
May 21, 2024
Merged

Migrate sci plugin to builtins #704

merged 13 commits into from
May 21, 2024

Conversation

jmcook1186
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Migrates SCI plugin code into if/builtins
Addresses #682

@jmcook1186 jmcook1186 self-assigned this May 8, 2024
@jmcook1186 jmcook1186 mentioned this pull request May 8, 2024
Closed
10 tasks
@jmcook1186 jmcook1186 changed the title Migrate SCI plugin to builtins Migrate sci plugin to builtins May 10, 2024
manushak
manushak reviewed May 15, 2024
View reviewed changes
src/builtins/sci/README.md Outdated Show resolved Hide resolved
src/builtins/sci/README.md Outdated Show resolved Hide resolved
src/builtins/sci/README.md Outdated Show resolved Hide resolved
src/builtins/sci/README.md Outdated Show resolved Hide resolved
@jmcook1186 jmcook1186 mentioned this pull request May 16, 2024
Open
@jmcook1186 jmcook1186 requested a review from manushak May 20, 2024 12:06
@jmcook1186 jmcook1186 linked an issue May 20, 2024 that may be closed by this pull request
Move sci to if/builtins #682
Closed
6 tasks
@jmcook1186 jmcook1186 merged commit 559e0db into main May 21, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the migrate-sci-to-builtins branch May 21, 2024 08:04
This was referenced Jun 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manushak manushak manushak approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@MariamKhalatova MariamKhalatova Awaiting requested review from MariamKhalatova

Assignees

@jmcook1186 jmcook1186

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move sci to if/builtins
3 participants
@jmcook1186 @manushak @narekhovhannisyan