Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for Boavizta Cloud Impact Model #70

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Conversation

gnanakeethan
Copy link
Contributor

  • Accepts array of objects or a single object as input.
  • Transforms the input from IMPL to Boavizta compatible data type
  • Allows raw input for ease of use.
  • Exposes "configure", "calculate" functions as expected by the IMPCON.

Closes #68

@gnanakeethan gnanakeethan requested a review from jawache July 28, 2023 10:28
@gnanakeethan gnanakeethan self-assigned this Jul 28, 2023
@gnanakeethan gnanakeethan changed the title Implementation for Boavizta CPU Impact Model Implementation for Boavizta Cloud Impact Model Jul 28, 2023
@gnanakeethan gnanakeethan marked this pull request as ready for review July 28, 2023 10:35
lib/boavizta.ts Outdated Show resolved Hide resolved
lib/boavizta.ts Outdated Show resolved Hide resolved
lib/boavizta.ts Outdated Show resolved Hide resolved
lib/boavizta.ts Outdated Show resolved Hide resolved
@gnanakeethan gnanakeethan force-pushed the boavizta-cloud-imp branch 4 times, most recently from 726ac39 to d5bb311 Compare August 2, 2023 05:09
@jawache jawache mentioned this pull request Aug 3, 2023
12 tasks
@jawache
Copy link
Contributor

jawache commented Aug 3, 2023

To fix the embodied issue let's add a configuration parameter called: expected-lifespan, with units of "years".
Then @gnanakeethan use the equation here https://github.com/Green-Software-Foundation/sci/blob/main/Software_Carbon_Intensity/Software_Carbon_Intensity_Specification.md#embodied-emissions to weight the embodied response from Boavizta's.

@jawache
Copy link
Contributor

jawache commented Aug 9, 2023

@gnanakeethan after some investigation I think we just need to use the LINEAR allocation method.

Linear means that this output changes with respect to the amount of time you input, so if you input more time the manufacturing carbon emissions reported increases.

    "gwp": {
      "manufacture": 0.086,
      "use": 0.01,
      "unit": "kgCO2eq"
    },

@jawache jawache mentioned this pull request Aug 10, 2023
13 tasks
@jawache
Copy link
Contributor

jawache commented Aug 10, 2023

Default
For embodied carbon, use LINEAR and take manufacturing as is.
For energy default is to take it as is from the PE section.

Configure It?

Copy link
Contributor

@jawache jawache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnanakeethan remove the python folder for cleanliness, this isn't needed (we're implementing in another ticket and in TS)

lib/boavizta.test.ts Outdated Show resolved Hide resolved
@gnanakeethan gnanakeethan force-pushed the boavizta-cloud-imp branch 2 times, most recently from 52c9701 to 6a68d39 Compare August 16, 2023 11:55
@jawache jawache mentioned this pull request Aug 16, 2023
8 tasks
Copy link
Contributor

@jawache jawache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawache
Copy link
Contributor

jawache commented Aug 17, 2023

@gnanakeethan can you please fix the conflicts and we can merge already with pre-approved from the project team.

Signed-off-by: Gnanakeethan <[email protected]>
@gnanakeethan
Copy link
Contributor Author

@jawache Conflicts resolved via Rebasing.

@gnanakeethan
Copy link
Contributor Author

@jawache I am merging this since it is already approved.

@gnanakeethan gnanakeethan merged commit 6473405 into dev Aug 18, 2023
@gnanakeethan gnanakeethan deleted the boavizta-cloud-imp branch August 18, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Boavizta SCI Cloud IMP
2 participants