-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation for Boavizta Cloud Impact Model #70
Conversation
726ac39
to
d5bb311
Compare
To fix the embodied issue let's add a configuration parameter called: expected-lifespan, with units of "years". |
b095dbd
to
9e55686
Compare
@gnanakeethan after some investigation I think we just need to use the LINEAR allocation method. Linear means that this output changes with respect to the amount of time you input, so if you input more time the manufacturing carbon emissions reported increases.
|
Default Configure It?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnanakeethan remove the python folder for cleanliness, this isn't needed (we're implementing in another ticket and in TS)
52c9701
to
6a68d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gnanakeethan can you please fix the conflicts and we can merge already with pre-approved from the project team. |
Fixes #68 Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
6a68d39
to
5a87d9a
Compare
Signed-off-by: Gnanakeethan <[email protected]>
@jawache Conflicts resolved via Rebasing. |
@jawache I am merging this since it is already approved. |
Closes #68