-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --stdout flag to CLI params #575
Add --stdout flag to CLI params #575
Conversation
1e96081
to
27cc1fc
Compare
wow that was fast- thanks, we'll look over this in our internal PR triage call tomorrow. |
27cc1fc
to
edc4520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - requested some small changes
import {sciEInputData} from '../test-data/sci-e'; | ||
|
||
import * as YAML from 'js-yaml'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please import libs from the beginning of the file, and then newline, then other internal dependencies
@@ -1,5 +1,5 @@ | |||
import {ExportLog} from '../../../builtins/export-log'; | |||
|
|||
import * as YAML from 'js-yaml'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same here
@@ -1,5 +1,5 @@ | |||
import {Context} from '../types/manifest'; | |||
|
|||
import * as YAML from 'js-yaml'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Signed-off-by: Abhinav Bansal <[email protected]>
edc4520
to
cda38e9
Compare
@narekhovhannisyan @jmcook1186 Addressed. Pls re-review. |
Hi @abhinavbansal19961996, I have executed the code locally, and everything looks fine! However, it's weird that if we are executing manifest without output and stdout flags, then it executes without any notification. So I'm pushing commit which will notify on console that none of stdout nor output flags are provided. |
Requested changes where fixed.
bfc1f8c
into
Green-Software-Foundation:main
Fixes #503
Types of changes
A description of the changes proposed in the Pull Request
This fixes this high priority issue: #503
passed