Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #34

Merged
merged 4 commits into from
May 25, 2023
Merged

Update README.md #34

merged 4 commits into from
May 25, 2023

Conversation

srini1978
Copy link
Contributor

Removed the word API and replaced it with SDK

Removed the word API and replaced it with SDK

Signed-off-by: Srinivasan <[email protected]>
@srini1978 srini1978 assigned srini1978, jawache and navveenb and unassigned srini1978 May 15, 2023
srini1978 added 2 commits May 15, 2023 06:10
Replaced the word API with the word SDK

Signed-off-by: Srinivasan <[email protected]>
Updated the architecture of the carbonQL project

Signed-off-by: Srinivasan <[email protected]>
Copy link
Contributor

@Oleg-Zhymolokhov Oleg-Zhymolokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small propositions for spelling

README.md Outdated
@@ -49,6 +49,14 @@ The carbonQL acts like a facade, it might call out to other APIs, CSV files, DBs

It provides a common interface to all the various models, makes opinionated decisions about which model to use and how its results should be transformed into the format you need for your calculations. In the above diagram we can see that the carbonQL is intended to connect to various backend carbon datasets like Climatiq, Cloud carbon co-efficients to bring back emissions data given the usage.

The interface definition would be generic i.e irrespective of the underlying data sources (hereafter referred to as models) being used , the method names across all tge data models would be the same. This would provide uniformity to the callers or users to use the carbonQL SDK. For example some of the methods we have envisioned in the interface include :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"across all tge data" - there's a typo. Should be "the"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oleg-Zhymolokhov Fixed the issue

README.md Outdated
@@ -6,19 +6,19 @@ The friction to measuring software emissions isn't that we need to know how, it'

## Solution

Therefore, the intent of this project is to build a single API codenamed *carbonQL* that you can use to measure your software emissions for every runtime environment. If your application runs on bare-metal servers in the private cloud, virtualized servers in the public cloud, mobile, desktop, and laptop end-user devices, the carbonQL API gives you data for all of them.
Therefore, the intent of this project is to build a SDK or a framework codenamed *carbonQL* that you can use to measure your software emissions for every runtime environment. If your application runs on bare-metal servers in the private cloud, virtualized servers in the public cloud, mobile, desktop, and laptop end-user devices, the carbonQL SDK gives you data for all of them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a SDK" -> "an SDK". S is pronounced as "ess".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oleg-Zhymolokhov As per latest understanding, removed all references to the word SDK and replaced it with framework

Removed the word SDK and changed it to framework
Addressed typos suggested by Oleg

Signed-off-by: Srinivasan <[email protected]>
@srini1978 srini1978 merged commit 56c2296 into dev May 25, 2023
@srini1978 srini1978 deleted the srini1978-patch-1 branch May 25, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants