Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ccf docs and add test impl #195

Merged
merged 2 commits into from
Oct 13, 2023
Merged

update ccf docs and add test impl #195

merged 2 commits into from
Oct 13, 2023

Conversation

jmcook1186
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Updates CCF documentation by:

  • adding detail about invoking the model via TS and impls.
  • Provides example invocations.
  • Adds an executable test impl.
  • Links to CCF website.

gnanakeethan
gnanakeethan approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@gnanakeethan gnanakeethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome... Looks great.

@gnanakeethan gnanakeethan merged commit 56d714e into dev Oct 13, 2023
2 checks passed
@gnanakeethan gnanakeethan deleted the ccf-docs branch October 13, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnanakeethan gnanakeethan gnanakeethan approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@jawache jawache Awaiting requested review from jawache

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcook1186 @gnanakeethan @narekhovhannisyan