Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes naming and unit errors in CCF and Boavizta models #193

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

jmcook1186
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Updates variable names across models from cpu to cpu-util for percentage CPU usage arriving from impl.
Removes multiplication by 100 that was previously implemented for converting fractional CPU usage to percentage. We expect cpu-util to arrive as a percentage.

Fixes #189

@gnanakeethan gnanakeethan merged commit b1ab11b into dev Oct 12, 2023
2 checks passed
@gnanakeethan gnanakeethan deleted the fix-ccf branch October 12, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CCF and Boavizta models expect cpu_util to be expressed as fractions
2 participants