Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init CONTRIBUTING doc #166

Merged
merged 3 commits into from
Sep 20, 2023
Merged

init CONTRIBUTING doc #166

merged 3 commits into from
Sep 20, 2023

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Initialized CONTRIBUTING.md doc file.

@narekhovhannisyan narekhovhannisyan marked this pull request as draft September 19, 2023 08:01
jmcook1186
jmcook1186 reviewed Sep 19, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
jmcook1186
jmcook1186 reviewed Sep 19, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
jmcook1186
jmcook1186 reviewed Sep 19, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
jmcook1186
jmcook1186 reviewed Sep 19, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
jmcook1186
jmcook1186 requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments but overall sgtm

@narekhovhannisyan narekhovhannisyan marked this pull request as ready for review September 20, 2023 12:55
jmcook1186
jmcook1186 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmcook1186 jmcook1186 merged commit 5a6fcb7 into dev Sep 20, 2023
@jmcook1186 jmcook1186 deleted the contributing-doc branch September 20, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narekhovhannisyan @jmcook1186