Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rimpl depth #145

Merged
merged 8 commits into from
Sep 15, 2023
Merged

Rimpl depth #145

merged 8 commits into from
Sep 15, 2023

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Rimpl script now supports nested children.

@narekhovhannisyan narekhovhannisyan linked an issue Sep 13, 2023 that may be closed by this pull request
Lifecycle Namespace Config #115
Closed
2 tasks
jmcook1186
jmcook1186 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm - all existing tests passing locally. Would prefer to see a new test added that pulls in an impl with several levels of nesting to confirm the new rimpl functionality code behaves as expected.

Also think it needs some detailed documentation as the naming is not super intuitive (I'm really referring to supercomputer - I like the name but it's not immediately obvious what it does. Not blocking, but this should be added at some point.

@narekhovhannisyan
Copy link
Member Author

Agree, we need to cover rimpl with tests also. Will think of different name selection which will be beautiful, but also fully reflective

@narekhovhannisyan narekhovhannisyan merged commit bddf413 into dev Sep 15, 2023
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the rimpl-depth branch September 15, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@jawache jawache Awaiting requested review from jawache

@gnanakeethan gnanakeethan Awaiting requested review from gnanakeethan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifecycle Namespace Config
2 participants
@narekhovhannisyan @jmcook1186