-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WattTime Model improvements #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnanakeethan logic seems good but the documentation and code clarity/structure still needs a lot of attention.
docs/implementations/watt-time.md
Outdated
observations: | ||
- timestamp: 2021-01-01T00:00:00Z | ||
location: | ||
latitude: 43.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we start nesting data in observations I'm worried it's going to get very messy. In the issue I asked to use just lat,lon, if it's not clear I meant to use it as a string, I believe the WattTime API also just expects it as a string also. Let's stick to that approach and keep to a flat structure for observations for now. If we choose to nest it should be for good reasons and after a lot of thinking to make sure it won't cause more complexity problems downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I will flatten out. I did not go for single string because there are different ways people write latitude and longitude.
In the graph way, you give longitude first and then the latitude. It makes some unnecessary confusion to be taken in same input.
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
356d872
to
fa55860
Compare
d877636
to
f1b7cbe
Compare
Adding example environment variable config. Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
f1b7cbe
to
0ec0776
Compare
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
lgtm |
Types of changes
A description of the changes proposed in the Pull Request
Adding documentation