Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WattTime Model improvements #140

Merged
merged 7 commits into from
Oct 1, 2023
Merged

WattTime Model improvements #140

merged 7 commits into from
Oct 1, 2023

Conversation

gnanakeethan
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Adding documentation

@gnanakeethan gnanakeethan marked this pull request as ready for review September 13, 2023 10:11
Copy link
Contributor

@jawache jawache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnanakeethan logic seems good but the documentation and code clarity/structure still needs a lot of attention.

docs/implementations/watt-time.md Show resolved Hide resolved
observations:
- timestamp: 2021-01-01T00:00:00Z
location:
latitude: 43.22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we start nesting data in observations I'm worried it's going to get very messy. In the issue I asked to use just lat,lon, if it's not clear I meant to use it as a string, I believe the WattTime API also just expects it as a string also. Let's stick to that approach and keep to a flat structure for observations for now. If we choose to nest it should be for good reasons and after a lot of thinking to make sure it won't cause more complexity problems downstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I will flatten out. I did not go for single string because there are different ways people write latitude and longitude.

In the graph way, you give longitude first and then the latitude. It makes some unnecessary confusion to be taken in same input.

docs/implementations/watt-time.md Show resolved Hide resolved
src/lib/watt-time/index.ts Outdated Show resolved Hide resolved
src/lib/watt-time/index.ts Outdated Show resolved Hide resolved
src/lib/watt-time/index.ts Outdated Show resolved Hide resolved
@gnanakeethan gnanakeethan linked an issue Sep 14, 2023 that may be closed by this pull request
3 tasks
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
docs/implementations/watt-time.md Outdated Show resolved Hide resolved
docs/implementations/watt-time.md Show resolved Hide resolved
docs/implementations/watt-time.md Show resolved Hide resolved
Adding example environment variable config.

Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
@jawache
Copy link
Contributor

jawache commented Oct 1, 2023

lgtm

@jawache jawache merged commit 2eea245 into dev Oct 1, 2023
2 checks passed
@jawache jawache deleted the watt-time-improvements branch October 1, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model Plugin - watttime
3 participants