Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Model Plugin Configuration Spec #110

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

jawache
Copy link
Contributor

@jawache jawache commented Sep 1, 2023

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

Updated the spec to describe how models are initialized and how we handle configuration in the project.

@jmcook1186
Copy link
Contributor

team agreed to merge - after fixing conflicts

@narekhovhannisyan narekhovhannisyan merged commit 3f01151 into dev Sep 14, 2023
@narekhovhannisyan narekhovhannisyan deleted the model-plugin-configuration branch September 14, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants