Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv-import plugin #1091

Merged
merged 14 commits into from
Dec 12, 2024
Merged

Add csv-import plugin #1091

merged 14 commits into from
Dec 12, 2024

Conversation

manushak
Copy link
Contributor

@manushak manushak commented Dec 6, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

A description of the changes proposed in the Pull Request

@manushak manushak linked an issue Dec 6, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

/**
* Checks if given string is URL.
*/
const isURL = (filepath: string) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manushak this and some of the other functions are duplicates, let's think of
optimal way

Copy link
Member

@narekhovhannisyan narekhovhannisyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comments above

@narekhovhannisyan
Copy link
Member

narekhovhannisyan commented Dec 12, 2024

@manushak update util name to csv helpers

@narekhovhannisyan narekhovhannisyan merged commit 991dde8 into main Dec 12, 2024
4 checks passed
@narekhovhannisyan narekhovhannisyan deleted the csv-import branch December 12, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add csv-import plugin to builtins
3 participants