-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add csv-import plugin #1091
Add csv-import plugin #1091
Conversation
Signed-off-by: Manushak Keramyan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
/** | ||
* Checks if given string is URL. | ||
*/ | ||
const isURL = (filepath: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manushak this and some of the other functions are duplicates, let's think of
optimal way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the comments above
Co-authored-by: Narek Hovhannisyan <[email protected]> Signed-off-by: Manushak Keramyan <[email protected]>
@manushak update util name to csv helpers |
Types of changes
A description of the changes proposed in the Pull Request