Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance plugins with an inline arithmetic feature #1004

Merged
merged 43 commits into from
Sep 17, 2024
Merged

Enhance plugins with an inline arithmetic feature #1004

merged 43 commits into from
Sep 17, 2024

Conversation

manushak
Copy link
Contributor

@manushak manushak commented Sep 6, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Adds inline arithmetic expressions to use basic mathematical operations directly within config parameters or inputs values in the manifest.
  • An inline arithmetic expression should start with = and must include one of the symbols *, +, -, or /. If an arithmetic operation is performed between constants (e.g., 2 * 2), the result is calculated without needing the = sign.
config:
  'input-parameter': '= 2 * carbon'
  coefficient: 2 * 2
  'output-parameter': '= 2 * "carbon-product"'
---
inputs:
  - timestamp: '2023-08-06T00:00'
    duration: 3600 * 60
    carbon: 30

@manushak manushak self-assigned this Sep 6, 2024
jmcook1186
jmcook1186 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@zanete zanete linked an issue Sep 9, 2024 that may be closed by this pull request
Make "inline" arithmetic work in manifests #970
Closed
4 tasks
@manushak manushak marked this pull request as draft September 9, 2024 12:54
@jmcook1186 jmcook1186 mentioned this pull request Sep 12, 2024
Open
@manushak manushak marked this pull request as ready for review September 16, 2024 10:56
manushak and others added 20 commits September 17, 2024 11:33
@manushak
feat(builtins): add inline arithmetic logic into plugins
ca6b523 
Signed-off-by: manushak <[email protected]>
@manushak
test(builtins): add tests related to inline arithmetic feature
796cf7e 
Signed-off-by: manushak <[email protected]>
@manushak
feat(package): update if-core version
27f6e27 
Signed-off-by: manushak <[email protected]>
@manushak
feat(config): add strings for explain feature
3e198bf 
Signed-off-by: manushak <[email protected]>
@manushak
feat(lib): update explain feature logic
ccec981 
Signed-off-by: manushak <[email protected]>
@manushak
feat(types): add ExplainStorageType type
cd877b1 
Signed-off-by: manushak <[email protected]>
@manushak
test(lib): update tests and add new ones
c4574a5 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
fix(lib): change default aggregation method
7d07ada 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
fix(builtins): add a bit of doc, remove additional 1 second
5a86cf3 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
test(builtins): update time sync
20e56ee 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(util): enable granular aggregation in helper
943921e 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(types): use aggregation options as method
4f01a8e 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(types): enable time and component aggregations
35f8142 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
fix(lib): update docs, improve readablity in initialize
b58cbbf 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(lib): use granular aggregation in explain
23bc5f9 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(lib): introduce granular aggregation to aggregate
5832a24 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(config): rename additional params to time metrics
ee6c2ab 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(builtins): use granular aggregation in time sync
3c07a4a 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(builtins): use granular aggregation methods in sci embodied
1f278ec 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(builtins): use granular aggregation methods in sci
f76ab33 
Signed-off-by: manushak <[email protected]>
narekhovhannisyan and others added 22 commits September 17, 2024 11:33
@narekhovhannisyan @manushak
feat(src): simplify if-run index
ae24412 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(util): introduce granular aggregation to validation
78de556 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(types): enable time and component aggregations in manifest
dc1ccc7 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
test(util): tune aggregation helper units
39367ac 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
test(lib): tune explain units
e9999d7 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
test(lib): tune aggregate units
dd88ca8 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
test(builtins): tune time-sync units
91180e0 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
feat(package): update if-core version
921f461 
Signed-off-by: manushak <[email protected]>
@narekhovhannisyan @manushak
fix(builtins): fix output param of sci embodied
116e48f 
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
feat(src): add support for appending to existing outputs
cda5681 
Signed-off-by: James Crowley <[email protected]>
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
test(lib): make the regroup intended behaviour clearer
4e8c5e1 
Signed-off-by: James Crowley <[email protected]>
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
test(lib): fix typos in test names
a9ab295 
Signed-off-by: James Crowley <[email protected]>
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
refactor(lib): refactor regroup so we can then include outputs
3d51191 
Signed-off-by: James Crowley <[email protected]>
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
refactor(lib): extract function for looking up group key value
c860286 
Signed-off-by: James Crowley <[email protected]>
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
refactor(lib): remove unnecessary spread
fa06cfa 
appendGroup already returns acc merged anyway

Signed-off-by: James Crowley <[email protected]>
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
feat(lib): apply regroup to outputs not just inputs
4aa79e1 
only when appending - otherwise outputs are lost if not already grouped.

Signed-off-by: James Crowley <[email protected]>
Signed-off-by: manushak <[email protected]>
@manushak
fix(builtins): minor fix
7279f92 
DCO Remediation Commit <[email protected]>

Hereby add my Signed-off-by to this commit: dd1cfb0
Hereby add my Signed-off-by to this commit: 575ecee
Hereby add my Signed-off-by to this commit: a841b3a

Signed-off-by: manushak <[email protected]>
@manushak
fix(builtins): minor fix
af3c600 
Signed-off-by: manushak <[email protected]>
@manushak
fix(builtins): minor fix
e3fd10f 
Signed-off-by: manushak <[email protected]>
@jamescrowley @manushak
feat(src): add support for appending to existing outputs
982cfca 
Signed-off-by: James Crowley <[email protected]>
@jamescrowley @manushak
feat(lib): apply regroup to outputs not just inputs
7618d8b 
only when appending - otherwise outputs are lost if not already grouped.

Signed-off-by: James Crowley <[email protected]>
@manushak
fix(builtins): fix linter error
f381e56 
Signed-off-by: manushak <[email protected]>
@manushak manushak merged commit 79a0ec4 into main Sep 17, 2024
2 checks passed
@manushak manushak deleted the inline-arithmetic branch September 17, 2024 08:19
@narekhovhannisyan narekhovhannisyan mentioned this pull request Sep 23, 2024
Closed
6 tasks
This was referenced Oct 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees

@manushak manushak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "inline" arithmetic work in manifests
4 participants
@manushak @narekhovhannisyan @jmcook1186 @jamescrowley