Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receiving the same error message twice #789

Closed
MariamKhalatova opened this issue Jun 6, 2024 · 4 comments · Fixed by #1076
Closed

Receiving the same error message twice #789

MariamKhalatova opened this issue Jun 6, 2024 · 4 comments · Fixed by #1076
Assignees
@narekhovhannisyan
Labels
blocked The issue is blocked and cannot proceed. bug Error, flaw or fault good-first-issue This issue is a good one for someone looking to get involved with this project/initiative.
Milestone
IF 1.0

Comments

@MariamKhalatova
Copy link
Contributor

Description of the Error

In case of error outputs the error message is printed twice.

Expected Behaviour

The error message should be visible only 1 time

Steps to Reproduce

  1. Run any manifest file but provide a wrong file path while running
Screenshot 2024-06-07 at 12 49 19 AM
@MariamKhalatova MariamKhalatova added the bug Error, flaw or fault label Jun 6, 2024
@jmcook1186 jmcook1186 added the good-first-issue This issue is a good one for someone looking to get involved with this project/initiative. label Jun 7, 2024
@jmcook1186 jmcook1186 moved this to Backlog in IF Jun 7, 2024
@DreamerChaserHAH
Copy link

@MariamKhalatova @jmcook1186 Is this okay?

Screenshot_2024-06-07_20-40-27

@jmcook1186
Copy link
Contributor

@DreamerChaserHAH thanks for your input - to diagnose further we'd need to know the command you ran and whether there was a valid manifest at the path you provided.

However, we are currently updating the way we handle errors in IF (#593) so better to wait to see if this gets fixed there - we'll leave this on pause until then.

@jmcook1186 jmcook1186 moved this from Backlog to Blocked in IF Jun 11, 2024
@zanete zanete added the blocked The issue is blocked and cannot proceed. label Jun 11, 2024
@zanete zanete added this to the Improve Trust milestone Jun 11, 2024
@DreamerChaserHAH
Copy link

Understood

@zanete
Copy link

zanete commented Jul 8, 2024

@jmcook1186 do we believe that this should no longer be the case in the new release?
cc @narekhovhannisyan @MariamKhalatova

@zanete zanete removed this from the Improve Trust milestone Jul 8, 2024
@zanete zanete moved this from Blocked to Ready in IF Nov 18, 2024
@zanete zanete moved this from Ready to In Progress in IF Nov 19, 2024
@zanete zanete added this to the IF 1.0 milestone Nov 19, 2024
@narekhovhannisyan narekhovhannisyan linked a pull request Nov 19, 2024 that will close this issue
Fix #789 #1076
Merged
6 tasks
@narekhovhannisyan narekhovhannisyan moved this from In Progress to Pending Review in IF Nov 19, 2024
@zanete zanete assigned manushak and unassigned manushak Nov 20, 2024
narekhovhannisyan added a commit that referenced this issue Nov 22, 2024
@narekhovhannisyan
Merge pull request #1076 from Green-Software-Foundation/fix-#789
4ab5ad2 
Fix #789
@github-project-automation github-project-automation bot moved this from Pending Review to Done in IF Nov 22, 2024
@github-actions github-actions bot mentioned this issue Dec 10, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narekhovhannisyan narekhovhannisyan

Labels
blocked The issue is blocked and cannot proceed. bug Error, flaw or fault good-first-issue This issue is a good one for someone looking to get involved with this project/initiative.
Projects
IF
Status: Done
Milestone
IF 1.0
Development

Successfully merging a pull request may close this issue.

Fix #789 Green-Software-Foundation/if
6 participants
@manushak @narekhovhannisyan @jmcook1186 @zanete @MariamKhalatova @DreamerChaserHAH