-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update explain behavior to support the visualizer flyout function. #1058
Update explain behavior to support the visualizer flyout function. #1058
Comments
@jawache assuming this is one is for @narekhovhannisyan ? |
@zanete yes, but let's make sure whatever format we come up with works for @osamajandali |
@jmcook1186 please refine this with acceptance criteria so @narekhovhannisyan could work on this, and after that it will be easier for @osamajandali to adjust visualiser code |
@narekhovhannisyan @zanete added detail to the ticket for the IF side of this. |
PR expected soon |
@jmcook1186 I was thinking it makes some sense for the plugins to also have optional textual descriptions same a parameters. Right now we're using long strings in the plugin name itself to describe what it is for, but perhaps we can have a description for the plugins themselves also in the initialise block. Maybe some plugins could return descriptions themselves and the built-ins you can define the description in the config. So energy-in-kwh could have a description that is more human readable with somewhat of an explanation as to why e.g. "convert energy to kwh so that it can be used in the XXX calculation methodology" Also I see you're point on the replication of data, but the manifest files are already super long. I vaguely remember I was against the idea of just fleshing out the initialize block in an output manifest originally with the explain data, I'm not sure what my argument was then but it's making sense now. It also has the advantage that the visualizer could also just display the config associate with the plugin when you hover over it, or just gives more freedom to Osama to get additional data related to a plugin and display it in the fly out. |
The vizualizer fly out needs to be able to show inputs and outputs properly, e.g. in this example I'm hovering over a pipeline and two outputs are highlighted. One is an input and one is an output, the current underlying data in the manifest file doesn't show inputs/outputs (yes, I know I asked for it in this way, I was wrong!) so we need to add them back in.
Can we also call the field in the manifest, "key" or something other than "explain", I feel explain should do more than just describe the fields.
Details for Narek
We basically want to revert the changes in this PR
#971
So instead of returning
we should instead return:
So the parameter details are organized by plugin, then inputs/outputs. The aggregation method should still be returned. It is understood that this will lead to repetition of the parameters in the explain block if theyare used in multiple plugins. This is fine, as long as the aggregation method and unit are the same for identically named parameters.
Example
Here's a snippet of the
explain
block from a manifest I just ran:and this is what it should look like after the proposed changes have been made:
If two instances of the same parameter are seen with different units or aggregation methods then we should error out.
The text was updated successfully, but these errors were encountered: