Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC - Manifest Visualiser 2 #1028

Open
2 of 8 tasks
Tracked by #1025
zanete opened this issue Sep 30, 2024 · 3 comments
Open
2 of 8 tasks
Tracked by #1025

EPIC - Manifest Visualiser 2 #1028

zanete opened this issue Sep 30, 2024 · 3 comments
Assignees
Milestone

Comments

@zanete
Copy link

zanete commented Sep 30, 2024

Why: Sub of #1025
What: Add helpful features to the visualiser, continuation from #951

Tasks

Landing page

  • Copy for the Visualiser landing page
@zanete zanete added this to the IF 1.0 milestone Sep 30, 2024
@zanete zanete moved this to In Design in IF Sep 30, 2024
@zanete
Copy link
Author

zanete commented Oct 21, 2024

@jawache please add your notes here 🙏 (unless you have created another issue in which case I'll merge)

@jawache
Copy link
Contributor

jawache commented Oct 23, 2024

Ok so there are I think four main things we need to address.

Landing Page

  • The landing page, it needs more copy and sample links which you can click to see various manifest file examples.

FlyOut

  • The flyout, the underling data right now isn't useful enough to make the flyout useful. We need to show inputs/outputs so the IF needs to add those back into the manifest so the flyout works.

Errors / Validation

  • If you put a manifest file in that doesn't quite conform, then it doesn't really give you an error. We need to at least return some error, or ideally some information to help them understand how to resolve.

Time!

We've got a lot still to figure out with time, we're discussing it at length in #1057.

  • If you put in a manifest file with like hourly or minute timesteps, the graph just shows days. If we are dealing with time we need a solution where the visualizer knows the time steps and can adjust the UX accordingly.
  • T1, T2, seems arbitrary. It might be ok but I'm wondering as we explore a better way of handling time in the IF whether we can deal with this better.
  • Visualizer isn't useful unless data is provided on a perfect grid of time which is an advanced type of manifest. It's very complex to provide data already on a perfect grid of time so you can show a top level time series graph. If that is the base case for the visualizer being useful, the majority of manifests won't be "visualizable".
  • One use case i'd like the visualize to be able to visualize many of the hackathon manifest files, e.g. this one for LLMs https://github.com/Jjing-Liang/LLMCarbon--/blob/main/example/llm-carbon-with-estimated-training-time2-result.yaml. That doesn't have a time grid, is complex to read so would benefit from a visualizer.

I'd like for us to break the visualizer up into two steps, first step is a version that works with most manifest files and without a time grid, we should decide what that looks like but really we are talking about a pie chart vs. a line graph and then the grid just has a total instead of a timeseries. Maybe that can be the default mode.

Then after we've properly landed on a solution for time in the manifest, we add functionality to the visualizer to support a time component. It's just a lot to figure out time and base case functionality in one iteration esp. considering we're still discussing how to fundamentally deal with time in a manifest file.

@jawache
Copy link
Contributor

jawache commented Oct 23, 2024

@zanete / @osamajandali / @jmcook1186 I've put my thoughts above and in sub-tickets, please comment and ajust/suggest.

@zanete zanete added this to D: Web Oct 23, 2024
@zanete zanete moved this to In Progress in D: Web Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Status: In Design
Development

No branches or pull requests

2 participants