Merge pull request #1066 from Green-Software-Foundation/fix-multiple-…

…aggregatino Fix multiple aggregation
Green-Software-Foundation · Oct 31, 2024 · f4259da · f4259da
2 parents 7011a2c + 4b9d14e
commit f4259da
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/if-run/lib/compute.ts b/src/if-run/lib/compute.ts
@@ -184,7 +184,6 @@ const computeNode = async (node: Node, params: ComputeParams): Promise<any> => {
       debugLogger.setExecutingPluginName(pluginName);
 
       outputStorage = await plugin.execute(outputStorage, nodeConfig);
-      console.log(outputStorage);
       debugLogger.setExecutingPluginName();
 
       node.outputs = outputStorage;

diff --git a/src/if-run/lib/initialize.ts b/src/if-run/lib/initialize.ts
@@ -3,6 +3,8 @@ import * as path from 'node:path';
 import {ERRORS} from '@grnsft/if-core/utils';
 import {PluginInterface} from '@grnsft/if-core/types';
 
+import {storeAggregationMetrics} from './aggregate';
+
 import {logger} from '../../common/util/logger';
 import {memoizedLog} from '../util/log-memoize';
 import {pluginStorage} from '../util/plugin-storage';
@@ -11,7 +13,6 @@ import {CONFIG, STRINGS} from '../config';
 
 import {Context, PluginOptions} from '../../common/types/manifest';
 import {PluginStorageInterface} from '../types/plugin-storage';
-import {storeAggregationMetrics} from './aggregate';
 
 const {
   PluginInitializationError,

diff --git a/src/if-run/util/aggregation-helper.ts b/src/if-run/util/aggregation-helper.ts
@@ -39,12 +39,12 @@ export const aggregateOutputsIntoOne = (
         const aggregationType = isTemporal ? 'component' : 'time';
 
         if (aggregationParams[aggregationType] === 'none') {
-          return acc;
+          continue;
         }
 
         if (aggregationParams[aggregationType] === 'copy') {
           acc[metric] = output[metric];
-          return acc;
+          continue;
         }
 
         acc[metric] = acc[metric] ?? 0;