Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure-importer test coverage #68

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Azure-importer test coverage #68

merged 2 commits into from
Apr 2, 2024

Conversation

manushak
Copy link
Contributor

@manushak manushak commented Apr 2, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • add full test coverage
  • make some small code improvements

@manushak manushak added tests related to unit or integration tests size: small quick task awaiting-dev-review PR is awaiting review from core dev labels Apr 2, 2024
@narekhovhannisyan narekhovhannisyan added dev-review-pass PR has been approved by core dev awaiting-qa PR is waiting for QA approval and removed awaiting-dev-review PR is awaiting review from core dev labels Apr 2, 2024
@MariamKhalatova MariamKhalatova added qa-pass PR has passed QA and removed awaiting-qa PR is waiting for QA approval labels Apr 2, 2024
@MariamKhalatova MariamKhalatova merged commit a25ec4c into main Apr 2, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the azure-importer-test branch April 2, 2024 19:42
@manushak manushak mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

Assignees
No one assigned
Labels
dev-review-pass PR has been approved by core dev qa-pass PR has passed QA size: small quick task tests related to unit or integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manushak @narekhovhannisyan @MariamKhalatova