Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return additional field->value mapping for terms queries #4278

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Return additional field->value mapping for terms queries #4278

merged 1 commit into from
Oct 25, 2017

Conversation

bernd
Copy link
Member

@bernd bernd commented Oct 23, 2017 •
edited
Loading

This mapping can be used to construct correct ES queries when using the QuickValues widget with stacked fields.

Fixes #4216

Note: This needs to be merged into 2.4

@bernd
Return additional field->value mapping for terms queries
c391b7c 
This mapping can be used to construct correct ES queries when using
the QuickValues widget with stacked fields.

Fixes #4216
@bernd bernd added this to the 2.4.0 milestone Oct 23, 2017
@ghost ghost assigned bernd Oct 23, 2017
@ghost ghost added the in progress label Oct 23, 2017
@bernd bernd changed the title Return additional field->value mapping for terms queries [WIP] Return additional field->value mapping for terms queries Oct 23, 2017
@bernd bernd changed the title [WIP] Return additional field->value mapping for terms queries Return additional field->value mapping for terms queries Oct 24, 2017
@bernd bernd requested review from kroepke and edmundoa and removed request for kroepke October 24, 2017 14:40
edmundoa
edmundoa approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@edmundoa edmundoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edmundoa edmundoa merged commit aada4c6 into master Oct 25, 2017
@edmundoa edmundoa deleted the issue-4216 branch October 25, 2017 12:56
edmundoa pushed a commit that referenced this pull request Oct 25, 2017
@bernd
Return additional field->value mapping for terms queries (#4278)
d36aa85 
This mapping can be used to construct correct ES queries when using
the QuickValues widget with stacked fields.

Fixes #4216

(cherry picked from commit aada4c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundoa edmundoa edmundoa approved these changes

Assignees

@bernd bernd

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bernd @edmundoa